Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh 3 - avoid tuples in internal code #8242

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Mesh 3 - avoid tuples in internal code #8242

wants to merge 13 commits into from

Conversation

janetournois
Copy link
Member

@janetournois janetournois commented May 30, 2024 •
edited
Loading

Summary of Changes

This PR introduces new structs to replace std::tuple's in internal code of Mesh_3, and in particular avoid the use of std::get<i>(tuple) that can be hardly readable, compared to the use of explicit member names like my_tuple_struct.dimension

Release Management

  • Affected package(s): Mesh_3
  • License and copyright ownership: unchanged

@janetournois
Copy link
Member Author

@lrineau what do you think about this internal change?

lrineau
lrineau reviewed May 30, 2024
View reviewed changes
Copy link
Member

@lrineau lrineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good!

Mesh_3/include/CGAL/Mesh_3/Refine_facets_3.h Outdated Show resolved Hide resolved
lrineau
lrineau approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@lrineau lrineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. That is a nice improvement over the existing code.

Mesh_3/include/CGAL/Mesh_3/Refine_facets_3.h Outdated Show resolved Hide resolved
@janetournois janetournois added this to the 6.1-beta milestone Jun 7, 2024
@janetournois janetournois force-pushed the Mesh_3-avoid_tuples-jtournois branch from 7d33fa9 to 8d6d934 Compare June 10, 2024 13:56
@janetournois janetournois marked this pull request as ready for review June 10, 2024 14:07
@sloriot
Copy link
Member

sloriot commented Jun 21, 2024

Several errors detected in CGAL-6.0-Ic-271 In Mesh_3, Poisson et Tet remeshing

@sloriot
Copy link
Member

sloriot commented Jul 1, 2024

Successfully tested in CGAL-6.0-Ic-277

@janetournois janetournois mentioned this pull request Sep 12, 2024
Open
15 tasks
@lrineau lrineau added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' and removed rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' labels Sep 26, 2024
@lrineau lrineau self-assigned this Oct 8, 2024
@sloriot sloriot added rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' Tested and removed Under Testing labels Oct 24, 2024
@sloriot
Copy link
Member

sloriot commented Oct 24, 2024

Successfully tested in CGAL-6.1-Ic-3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrineau lrineau lrineau approved these changes

Assignees

@lrineau lrineau

Labels
Enhancement Pkg::Mesh_3 rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' Tested
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@janetournois @sloriot @lrineau