-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh 3 - avoid tuples in internal code #8242
base: master
Are you sure you want to change the base?
Mesh 3 - avoid tuples in internal code #8242
Conversation
@lrineau what do you think about this internal change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. That is a nice improvement over the existing code.
…tournois # Conflicts: # Mesh_3/include/CGAL/Mesh_3/Refine_facets_3.h
7d33fa9
to
8d6d934
Compare
Several errors detected in CGAL-6.0-Ic-271 In Mesh_3, Poisson et Tet remeshing |
Successfully tested in CGAL-6.0-Ic-277 |
Successfully tested in CGAL-6.1-Ic-3 |
Summary of Changes
This PR introduces new
struct
s to replacestd::tuple
's in internal code of Mesh_3, and in particular avoid the use ofstd::get<i>(tuple)
that can be hardly readable, compared to the use of explicit member names likemy_tuple_struct.dimension
Release Management